Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: kustomize component for base url #2645

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Jul 24, 2024

Background

#2609 added support for base url. examples are missing.

Change Summary

Add a custom-base-url kustomize component

Related PRs or Issues

PR #2609

@aslafy-z aslafy-z marked this pull request as ready for review July 24, 2024 12:38
@aslafy-z aslafy-z requested review from yoshi-approver and a team as code owners July 24, 2024 12:38
@NimJay
Copy link
Collaborator

NimJay commented Jul 24, 2024

The kubevious GitHub check will pass once #2646 is merged and we update the source branch for this pull-request.

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful job, @aslafy-z! 👏
Approved.

(I have not tested this Kustomize component myself. But I trust you've done adequate testing on your end.) :)

We'll merge this once #2646 is merged.

@NimJay NimJay merged commit d91d669 into GoogleCloudPlatform:main Jul 25, 2024
6 checks passed
@aslafy-z aslafy-z deleted the patch-3 branch July 25, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants